James Acklin

Results 52 comments of James Acklin

OK, got it -- wasn't sure what you meant last time. Back to the lab...

End results look great, will leave the code review to others. Nice work!

@dnbrwstr Thanks for the feedback. I've: - Moved all theme updating logic into the shared store via updateTheme - Removed the redundant syncing in ThemeScreen.tsx that's already handled by subscription...

@Fang- Finally ready for review! Thanks for your patience.

That's a bit surprising, since that was precisely what useLivePosts is supposed to do. Let me see...

> Could we get Eli to look at this icon? Would be nice to be more consistent with the rest of our icon set. Sure thing. I think the one...

Does this replace #3999?

@dnbrwstr PTAL; I found an opportunity to unify the options themselves with a hook to be used in ChatOptionsSheets even if it's a different interface (ActionGroup vs radio buttons).

Moving back to draft so we can have a discussion with design.