James Prevett
James Prevett
I believe the test fails have to do with `_isDirty` checks, can anyone confirm or disprove?
@Popov72 @sebavan I did some diffing and found the only difference between the reference and PR scenes were two unique IDs. [diff.txt](https://github.com/BabylonJS/Babylon.js/files/11236024/diff.txt) (you may want to change the file type...
@Popov72 No pressure on getting this PR merged immediately, we have time.
Sure @sebavan, though I'd like to get it passing the tests before I look at the performance impacts. Just a thought, it may be beneficial to use array access instead...
@Popov72 `FromArray` was been giving a lot of trouble. > In a static function, `this` refers to the class in which the static function is defined `this` in a static...
> I love the overall idea, let's move it as a draft until the 6.0 version will be released. @sebavan Since 6.0 is out I'm going to mark it as...
@kzhsw Thank you so much for the reviews. Another set of eyes helps to catch things missed.
Vis tests failed on "Baked Vertex Animation" because [PG#11](https://playground.babylonjs.com/?snapshot=refs/pull/14235/merge#14WJWW#11) calls `Matrix.toArray` and expects an array as the return value, which is incorrect behavior. This is fixed in [PG#13](https://playground.babylonjs.com/?snapshot=refs/pull/14235/merge#14WJWW#13).
I've made the following changes to the PR (see the first comment): - Removed `Scalar` from standardization - Fixed some example code - Separated some of the proposal to be...
> > Vis tests failed on "Baked Vertex Animation" because [PG#11](https://playground.babylonjs.com/?snapshot=refs/pull/14235/merge#14WJWW#11) calls `Matrix.toArray` and expects an array as the return value, which is incorrect behavior. This is fixed in [PG#13](https://playground.babylonjs.com/?snapshot=refs/pull/14235/merge#14WJWW#13)....