James Mitchell

Results 232 comments of James Mitchell

With the changes in this PR, I'm seeing an approx. ~~27%~~ 9% loss in performance in the test file `tst/extreme/grahom.tst` with this branch: ~~~ gap> Test("~/digraphs/tst/extreme/grahom.tst"); Digraphs package: extreme/grahom.tst msecs:...

@Joseph-Edwards any chance you can run this through valgrind again? I think I might have inadvertently force pushed and deleted some of Daniel's fixes :(

Thanks @Joseph-Edwards, if you could push the old branch to your fork that'd be awesome! Also the new valgrind action would be just fine, where is that exactly?

Thanks @Joseph-Edwards I figured out how to call the valgrind job, and thanks for the push too!

Reopening so that I remember about it when making a release

We could also add `IsOrderFilter` by replacing `downwards` with `upwards` in the original comment.

@zljlzljlz Do you think you could try to implement a method for `IsOrderFilter` which would be almost identical to the method that Daniel did for `IsOrderIdeal`?

~Thanks for the report @fingolfin, I'm a bit confused though. Is this a problem in the Semigroups package or the Digraphs package? With libplanarity or libsemigroups? There's a mixture of...

Thanks @fingolfin, I understood this after reading your issue properly, I did not pay enough attention the first time :( I'll be happy to accept a PR if one is...

Yup, he deleted his computer. But on the plus side I think @reiniscirpons is now working on it.