James Mitchell
James Mitchell
Might even make sense to do something like we do is Semigroups and mark `DigraphDijkstra` as obsolete: https://github.com/semigroups/Semigroups/blob/7cc3070a8fda8d9b866b5864357dff491c133eb9/gap/obsolete.gi#L11
This is dependent on #742, and should be updated before being merged.
> It seems like g++'s `--enable-compile-warnings` flag complains about the use of `deprecated_thing_a` in `deprecated_thing_b`, even if `deprecated_thing_b` never gets used anywhere. One way we could get around this is...
> I think this is good to go now. I've addressed all of the points raised in @james-d-mitchell's previous review, but am happy to make more changes if there are...
> I think this is good to go now. I've addressed all of the points raised in @james-d-mitchell's previous review, but am happy to make more changes if there are...
I think we can close this, since we are now checking for compiler warnings in the CI
@MarkToner looks like there's lots of good stuff in this PR, can you please fix the linting issues, and then we will give this a proper review? Thanks!
Thanks @Joseph-Edwards can you please rebase onto v3, so that the changes you made for cpplint are picked up?
Great! Thanks @Joseph-Edwards
Resolved by recent pr.