James
James
I'd be happy to help with this task if I can
Yes it looks like the only difference now between our fork and upstream `v0.37.0-rc1` is the events endpoint, which we aren't using. https://github.com/tendermint/tendermint/compare/v0.37.0-rc1...heliaxdev:tendermint:ledger-main So we could switch to using upstream...
Related: https://github.com/anoma/namada/issues/377 We should look to remove `BlockHeight(0)` in general from our code since it doesn't exist (and change `BlockHeight::default()` to be `BlockHeight(1)` instead of `BlockHeight(0)`)
NB: there is now already `checked_sub`, just need a `checked_add` method (+ some test coverage) https://github.com/anoma/namada/blob/76169dcdaf15911ac2f69dec78604e18c4c5b259/core/src/types/token.rs#L74-L79
This would be super useful for tests and automation, the most useful commands to have this output for would be `namadac balance` and the various `namadaw address` subcommands.
For developing against Tendermint v0.37, would HEAD of `main` branch be the best thing to track for the time being?