PePe Amengual

Results 514 comments of PePe Amengual

> @jamengual - I'm not seeing a clear issue with the tests. > > Also, are the image build from branches available on ghcr or elsewhere? I created a PR...

Looks good to me , I will say we should add some docs about the changes on this new comment splitting

@geoff-kruss could you check the lint errors and the tests?

@adam-verigin looking at this make me think if this is fully backwards compatible?

sorry Adam, we have been very busy lately. This PR could still be valid for other people. We could still leave it open until we have some time.

> One issue with changing the format of the locking key is that keys are persisted outside of a running atlantis process (i.e. in boltdb or redis), so an in-place...

This looks good to me, what is left to do here?

@rgs1 could you fix the conflicts please?

@rgs1 can you check the tests? Thanks.

Code looks good to me , thanks @javking07 , you can test your changes when the image gets build in your fork and report back