notion-py icon indicating copy to clipboard operation
notion-py copied to clipboard

Update schema

Open ag0n1k opened this issue 4 years ago • 1 comments

Hi!

I was surprised that creation collection properties is not yet available. So here it is!

This PR does not provide:

  1. "update" of current properties (change types)
  2. "delete" current properties

So only add new property.

The smoke_tests are fine, but with only "edit" perms there are errors:

  1. The search the whole space does not work
# search the entire space
assert row1 in client.search_blocks(search=special_code)
assert row1 not in client.search_blocks(search="penguins")
assert row2 not in client.search_blocks(search=special_code)
assert row2 in client.search_blocks(search="penguins")
  1. The deletion does not work

Maybe the smoke tests instruction needs update that smoke tests requires admin perms?

Thanks in advance!

ag0n1k avatar Feb 07 '21 12:02 ag0n1k

Okay, suddenly, the update and deletion works well. Take me some time to understand it

ag0n1k avatar Feb 08 '21 00:02 ag0n1k