jiffy
jiffy copied to clipboard
Ideas for Jiffy PR
What does this PR do?
With reference to #118 some of the changes that I find logical are added. isSame
-> isSimilar
since we are also taking into account the units which can be misleading in some cases. Equality operator is overloaded. Tests have been changed accordingly.
isJiffy
and isDateTime
removed. Functionality can be achieved using the is
operator.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (a fix or feature that would cause existing functionality to change)
Screenshots
NA
Checklist
- [x] Directed the PR to
develop
branch and not themaster
branch - [x] Wrote additional tests, if needed
- [x] All tests have passed
- [x] I have updated the documentation accordingly, if needed.
@AadumKhor and @calvintam236 It will be best if we could have three PRs for each of the three issues, for easy tracking and reviewing
- Set the
isJIffy
andisDateTime
to depreciated and update the usage of this function with theis
operator - Adding the
==
,>
,<
,>=
and<=
operators for theisSame
,isAfter
,isBefore
, isSameOrBeforeand
isSameOrAfter` functions respectively - Adding the
isSimilar
function
What if this PRs focuses on the first issue and create other two PRs for the remaining two
Closing this because a new breaking change has been released