Jalil David Salamé Messina

> > As far as I can tell, this happens due to not handling `include: context-name` properly. > > This requires support for `extends` - see https://github.com/trishume/syntect/issues/323 I'll check the...

I was not building with `-F metadata`, I fixed all tests that were failing because of that.

I'm looking at how to implement extends (in a different PR). My initial idea is to add an error for `ExtendNotFound` when loading a syntax that extends another one, then...

The test failure is due to serde auto detecting nightly and trying to enable unstable features. We could update to a newer nightly to fix the issues, but really, serde...

> I guess that is why there is a separate linking step at the moment - maybe it would be possible to do the work there? Could you point me...

> The linking is done when building the syntax set: > > https://github.com/trishume/syntect/blob/de715e5a8194ecaf0d0d78fbdd97add54277ffbd/src/parsing/syntax_set.rs#L658 What I would need to do then, is delay loading syntaxes when I find an `extends` keyword,...

Rebased on top of `master`, this pulls in fixes for the nightly tests. Please re-run the CI

I'll look at the failures this afternoon, thanks for running the CI c:

I don't understand how the tests work, specifically, how `make assets` works, what is failing and how I go about fixing it. I figured out I could update the known...

> Does it make sense to change the known failure files? If so, I've done it in [jalil-salame#1](https://github.com/jalil-salame/syntect/pull/1). Although this seems relatively sensible within the context of this change (please...