Shouldn't FilmFacade constructor be package private?

[mkrzywanski]

Just a simple question. Shouldn't FilmFacade constructor be defined as package private? Right now it is defined as public but client code cannot instantiate it with it because it's dependencies are package private so client code (for example in different package) cannot use it. It can be instantiated only by using Spring and having FilmConfiguration class scanned.

[jakubnabrdalik]

You are correct, that should be package scoped. Perhaps I should update this sample project.

[mkrzywanski]

I can file a PR for this simple change if you want.

[jakubnabrdalik]

If you'd like to, sure, but I'm thinking about updating the whole thing to a more up-to-date version (I implement these requirements live a few time every year).