KSpigot icon indicating copy to clipboard operation
KSpigot copied to clipboard

Add centeredMessage to GeneralExtensions

Open kxmpxtxnt opened this issue 3 years ago • 24 comments

kxmpxtxnt avatar Apr 12 '22 12:04 kxmpxtxnt

sorry, forgot something

kxmpxtxnt avatar Apr 12 '22 12:04 kxmpxtxnt

nvm, i forgot nothing, im just dumb

kxmpxtxnt avatar Apr 12 '22 12:04 kxmpxtxnt

someone took my confidence I look again

kxmpxtxnt avatar Apr 12 '22 17:04 kxmpxtxnt

Don't close the PR, draft PRs are there for this.

jakobkmar avatar Apr 12 '22 17:04 jakobkmar

Okay

kxmpxtxnt avatar Apr 12 '22 17:04 kxmpxtxnt

what do you think of the idea so far?

kxmpxtxnt avatar Apr 12 '22 17:04 kxmpxtxnt

nice idea but won't work properly because of this setting

img

mooziii avatar Apr 12 '22 19:04 mooziii

yes, unfortunately you can only do this with the default value... I hope that spigot will eventually release a function that allows to get the chatsize

kxmpxtxnt avatar Apr 12 '22 19:04 kxmpxtxnt

Spigot cannot provide such a function since the client does not send that information to the server.

jakobkmar avatar Apr 12 '22 19:04 jakobkmar

this is the problem

kxmpxtxnt avatar Apr 12 '22 19:04 kxmpxtxnt

so you can look over it again, now several lines etc should work for the time being

kxmpxtxnt avatar Apr 12 '22 19:04 kxmpxtxnt

I mean, there is already Player#getClientOption(ClientOption.CHAT_VISIBILITY), for example, so maybe something like the size will be included soon.

kxmpxtxnt avatar Apr 12 '22 19:04 kxmpxtxnt

I don't think mojang will implement this because there is no reason for it to be sent to the server.

mooziii avatar Apr 12 '22 19:04 mooziii

yes unfortunately, but hope dies last xd

kxmpxtxnt avatar Apr 13 '22 05:04 kxmpxtxnt

would be something for Pacmc that the "client" always sends this value per packet to the server :D

kxmpxtxnt avatar Apr 13 '22 05:04 kxmpxtxnt

would be something for Pacmc that the "client" always sends this value per packet to the server :D

you don't have to answer, it's wishful thinking

kxmpxtxnt avatar Apr 13 '22 05:04 kxmpxtxnt

Should I then close the pr or is there any hope that it will be implemented

kxmpxtxnt avatar Apr 14 '22 07:04 kxmpxtxnt

I wouldn't merge this until there is a way to get the chat width on the server. As long is that is not possible, this feature is way too unstable.

jakobkmar avatar Apr 14 '22 13:04 jakobkmar

Ok, that's fine, too bad

kxmpxtxnt avatar Apr 16 '22 10:04 kxmpxtxnt

would it be an idea if we create an insecure/instable branch or something where we put such prs in that people who want to use it can take it?

kxmpxtxnt avatar Apr 18 '22 11:04 kxmpxtxnt

People who need such features can create them themselves. Maintaining multiple branches is unnecessary work in my opinion

0utplay avatar Apr 18 '22 11:04 0utplay

understandable

kxmpxtxnt avatar Apr 18 '22 11:04 kxmpxtxnt

genial

r0yzer avatar May 02 '22 13:05 r0yzer

flerdammt

flerbuster avatar May 02 '22 13:05 flerbuster