GitFlow.VS icon indicating copy to clipboard operation
GitFlow.VS copied to clipboard

Added bugfix actions.

Open olivermue opened this issue 6 years ago • 5 comments

A bugfix behaves the same as a feature (despite the prefix). So simply the feature stuff was copied and adopted to bugfix.


This change is Reviewable

olivermue avatar Nov 07 '18 13:11 olivermue

Thanks for the PR!

For some reason the extension hangs when I click on the GitFlow icon in Team Explorer. It's consistent, I've rebuilt the branch from scratch.

Any idea what could cause this? Which version of VS have you been using when developing and testing this?

jakobehn avatar Nov 20 '18 20:11 jakobehn

Okay, you got me.

I couldn't test it on my machine, cause a bunch of dependency DLLs are missing (especially Microsoft.TeamFoundation.Controls, Microsoft.TeamFoundation.Client, Microsoft.TeamFoundation.Git.Provider). Due to the fact that I have VS 2017 installed only they are not available. I just wrote the code and hoped for the best.

So if it doesn't work, give me a week or two (currently I have a bunch of other tasks on my desk). I'll install VS 2015 and try to find the reason.

olivermue avatar Nov 21 '18 07:11 olivermue

No worries! :-)

I might look into it a bit more, I couldn't spot anything that was wrong when I looked through the changes.

Btw, you shouldn't have to have VS2015 installed, as long as you build the correct configuration (there is one for each version of VS, that brings in the corresponding references)

jakobehn avatar Nov 21 '18 18:11 jakobehn

The problem is, that I have installed VS 2017 (15.x) only. This also uses the folder C:\Program Files (x86)\Microsoft Visual Studio 14.0, but the subfolder Common7\IDE\CommonExtensions\Microsoft\TeamFoundation is missing. So by using the Debug or Release configuration (cause VS2013 and VS2015 doesn't match) it tries to find Microsoft.TeamFoundation.Client.dll, Microsoft.TeamFoundation.Controls.dll and Microsoft.TeamFoundation.Git.Provider.dll which don't exist on my machine. I already checked my installed features with the installer, but I can't see anything that is not already enabled.

olivermue avatar Nov 22 '18 07:11 olivermue

I'm looking forward to this feature. Any news on when it might be done?

cremor avatar Jan 31 '19 13:01 cremor