Results 34 comments of Jakob Meier

Hi @DevSabb, Yes you are very much welcome to work on this! Thank you for your interest! :) I like the suggested format. Your example isn't 100% clear on this,...

Currently known values are: ``` BLOCK-MEASUREMENT-OVERHEAD HIGH-VARIANCE NEG-LEAST-SQUARES NEGATIVE-COST SUBTRACTION-UNDERFLOW ``` The longest is 26 characters. It is possible that we will have longer strings at some point. If it...

Yes, exactly. So far, we only see when the uncertain reason changes. If the uncertain flag stays the same but it has relative changes > 10%, it should be marked...

I believe instead of showing uncertain results only once, we should probably always show a list of uncertain results. When I initially wrote this issue, this would have been quite...

> remove `_EVMError` Is this just for `FunctionCallError`? Or also for `FunctionCallErrorSer`? The former seems we can just delete it without second thoughts. The latter I am not sure how...

Hm, removing `AnyEq` isn't quite as easy as I thought. I missed that `VMLogicError` also contains `AnyError`. Gotta admint, I don't understand why `VMLogicError` requires `PartialEq`. But when remove it,...

If we merge this change first, I can finalise #7578 without adding temporary code only to deal with capacity configuration that we want to ditch anyway.

Thanks for the review @matklad! I think I addressed all your comments. cc also @Longarithm, to be very clear here, this change is going to have an effect on existing...

Note to self: Add a comment in CHANGELOG after rebasing

> LGTM. Is it right that after this cache for shard 3 will hold less entries, but we don't care much because we have prefetching as well? yes, that's exactly...