Medium.js icon indicating copy to clipboard operation
Medium.js copied to clipboard

Events functionality

Open alexrass opened this issue 12 years ago • 8 comments

A few things:

  1. Added onblur and onfocus events
  2. Esc event on inline edit will return value to original before element was edited and blur the element
  3. Debug mode is off by default

alexrass avatar Aug 19 '13 18:08 alexrass

Nice work. I am just curious why you didn't use dispatchEvent instead of a callback.

salzhrani avatar Aug 20 '13 20:08 salzhrani

@alexrass I have a number of fixes in my branch as well, and I'd like to use this. The diff is hard to read though because of the whitespace, can you retain the original indentation? (which threw me off as well).

kshahkshah avatar Sep 09 '13 20:09 kshahkshah

Can you update this patch to the latest so we can merge it?

robertleeplummerjr avatar Jun 17 '14 12:06 robertleeplummerjr

I haven't tested this piece of code, I haven't used it in a while so if you do decide to merge it in, make sure it actually works

alexrass avatar Jul 02 '14 16:07 alexrass

Hey, i would love to see this also with onKeyup and onKeydown to hook some functionality to the rather simple inline mode.

alejandroiglesias avatar Jul 04 '14 00:07 alejandroiglesias

We had some reorganization of the code base to better work with multi instances and browser compatibility. Would you be able to update your merge one last time, sorry for the frustration.

robertleeplummerjr avatar Jul 26 '14 13:07 robertleeplummerjr

Hey @alexrass would you have some time to update your merge? These events are useful.

jonataswalker avatar Jul 03 '15 21:07 jonataswalker

Agreed.

On Fri, Jul 3, 2015 at 5:44 PM, Jonatas Walker [email protected] wrote:

Hey @alexrass https://github.com/alexrass would you have some time to update your merge? These events are useful.

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/pull/14#issuecomment-118430994.

Robert Plummer

robertleeplummerjr avatar Jul 03 '15 23:07 robertleeplummerjr