Medium.js icon indicating copy to clipboard operation
Medium.js copied to clipboard

Ignoring items to clean

Open bearded-avenger opened this issue 10 years ago • 9 comments

Really appreciate the work that you guys have put into this. I'd like to make a donation to help further development and chat about how I've implemented this. Can you point me in the right spot?

As for this query, I'm wondering if it's possible to ignore a certain element while having tags,attributes set to null? I realize this may be redundant but, the reason I'm asking, is that <script> tags seem to be getting wrapped/cleaned my medium. Is this intentional? Here's a screen of what I'm seeing. Any advice on how to eliminate this?

image 2014-12-29 at 12 33 18 pm

I am aware of the insertHtml , however these items are existing/and-or appended with drag and drop.

bearded-avenger avatar Dec 29 '14 18:12 bearded-avenger

The best approach to inserting script into a page that control what is in the contenteditable area would be to have a designated area for js beside the contenteditable element. We use a similar approach with wikiLingo, and are event able to use undo and redo with it. As far as a donation, I'm the project lead, but not the originator of the project. While I do like money to support my family, either I would ask him or enlist my help directly as a consultant.

robertleeplummerjr avatar Dec 30 '14 02:12 robertleeplummerjr

Unfortunately this won't work. The user isn't directly inserting any scripts. These are found within pieces of markup that are being dragged onto the page. Example: http://cl.ly/image/1M3B0f3m0b1H

medium.js is inserting those p tags within a div and it's breaking the js instantiation method there in that screenshot above. Is there any way to prevent medium.js acting on a specific tag? ideally i'd like to prevent anything from touching anything within a specific class.

Here's another screenshot of this "component" and those p tags within it that i'm trying to avoid. http://cl.ly/image/2x1n1i0Y421i

bearded-avenger avatar Dec 30 '14 02:12 bearded-avenger

Absolutely! Can we setup a meeting and I can show you how?

robertleeplummerjr avatar Dec 30 '14 03:12 robertleeplummerjr

That would be really awesome I truly appreciate that!

bearded-avenger avatar Dec 30 '14 03:12 bearded-avenger

Cool! I would also like to point out the contenteditable can be used recursively. So if you have a div that is editable with tabs that are not and tab contents that are, contenteditable would be set to true on the div, false on the tabs, and true on the tab contents.

robertleeplummerjr avatar Dec 30 '14 12:12 robertleeplummerjr

Yes! That's similar to how I have this setup. The "components" that are dragged into the post have contenteditable="false" on them (however medium is still inserting p tags within this). These components with contenteditable="false" are nested within the editor that has contenteditable="true".

The components are not directly editable which is great. I"d just like to avoid medium inserting p tags into a specific div located inside the editor.

ignore: '.class'

would be epic...

bearded-avenger avatar Dec 30 '14 14:12 bearded-avenger

Interesting. While I do like the use of selectors, I do not like the impact they have on the overall performance. Would something more like: ignoreClasses: ['class'] work?

robertleeplummerjr avatar Dec 30 '14 15:12 robertleeplummerjr

That would work Robert! Really appreciate that.

bearded-avenger avatar Dec 30 '14 15:12 bearded-avenger

/me high fives Nick

On Tue, Dec 30, 2014 at 10:39 AM, Nick Haskins [email protected] wrote:

That would work Robert! Really appreciate that.

— Reply to this email directly or view it on GitHub https://github.com/jakiestfu/Medium.js/issues/124#issuecomment-68366386.

Robert Plummer

robertleeplummerjr avatar Dec 30 '14 15:12 robertleeplummerjr