klsh icon indicating copy to clipboard operation
klsh copied to clipboard

Modifications made on HammingANN class

Open ghost opened this issue 9 years ago • 5 comments

Query bits were given same permutation as that of the training data bits and searching was done for each permutation of bits to find the approximate nearest neighbor.

ghost avatar Feb 08 '16 06:02 ghost

I can't say I fully understand the change, and part of that is due to the fact that I haven't thought about this algorithm in a year and a half. Can you give more detail on what the problem was, and what you did to fix it?

jakevdp avatar Feb 08 '16 14:02 jakevdp

THanks – that makes sense.

Would it be possible to add a unit test to explicitly check that this fix is working?

jakevdp avatar Feb 11 '16 23:02 jakevdp

Yes, I will add a unit test to check the fix works.

ghost avatar Feb 14 '16 06:02 ghost

Thanks! I'll look for your new commit.

jakevdp avatar Feb 16 '16 21:02 jakevdp

Regarding unit test, I am not able to derive a relation between epsilon and accuracy. When you get time, can you share your thoughts on how it can be done ?

ghost avatar Feb 19 '16 07:02 ghost