Jake Vanderplas
Jake Vanderplas
That seems like a lot of boilerplate... seems like we want something like this? ```python def orthogonal(scale: RealNumeric = 1.0, column_axis: int = -1, dtype = None) -> Initializer: default_dtype...
It looks like there are some CI failures – please take a look!
You'll need to rebase on the main branch to pick up the last several months of updates.
Hi - sorry for having lost context on this in the last few months, but I'm not sure I understand what asymmetry you're referring to.
Just to confirm, this is on the Apple metal backend, yes? (All of this should work fine on non-experimental backends)
Thanks for looking at this! ParamSpec seems like it could be interesting; that said it still looks to be relatively unstable and probably the remarks [here](https://jax.readthedocs.io/en/latest/jep/12049-type-annotations.html#avoid-unstable-typing-mechanisms) still apply.
We've updated mypy to 1.4.1 in the meantime, and #17147 bumps it to 1.5.0 – can you sync your PR to the current main branch?
As soon as the new mypy version is mirrored at https://github.com/pre-commit/mirrors-mypy, we can bump the version in the pre-commit configuration here: https://github.com/google/jax/blob/5ed692809da29ff4fd9a89faee9af6d4b41c7056/.pre-commit-config.yaml#L30 It looks like the mirror update will happen...
#18066 updates mypy to v1.6.0
We'll drop Python 3.9 sometime after April 2024, following NEP 29 (see https://jax.readthedocs.io/en/latest/deprecation.html).