OtakuWorld icon indicating copy to clipboard operation
OtakuWorld copied to clipboard

F-Droid

Open linsui opened this issue 2 years ago • 23 comments

Is your feature request related to a problem? Please describe. Could you please publish the app on F-Droid? Thanks!

Describe the solution you'd like I can help package and submit it.

linsui avatar May 08 '22 10:05 linsui

I would love some help. I've looked into it and couldn't really understand what needed to be done. However, I haven't really been able to work on this project the last couple of days and the next few weeks. I should be primed to continue working by next month.

jakepurple13 avatar May 08 '22 10:05 jakepurple13

I can help you! I'll package it and make an MR. Thanks!

linsui avatar May 08 '22 10:05 linsui

Is that possible to remove Firebase? It's non-free and not allowed in F-Droid.

linsui avatar Jun 19 '22 11:06 linsui

It is...The reason why I added it in the first place is so that people can log in and gain access to their favorites and things read/watched without needing to do steps to transfer data. Plus, crashlytics is a huge plus for when debugging crashes. What I can try to do is modify the builds so there's a firebase version and a non-firebase version with descriptions of what the difference between the two are.

jakepurple13 avatar Jun 19 '22 11:06 jakepurple13

What I can try to do is modify the builds so there's a firebase version and a non-firebase version with descriptions of what the difference between the two are.

A flavor without firebase/google play service/mlkit would be good. Thanks!

linsui avatar Jun 19 '22 11:06 linsui

I'll see what I can do. It probably won't be easy.

jakepurple13 avatar Jun 19 '22 11:06 jakepurple13

Thanks!

linsui avatar Jun 19 '22 11:06 linsui

Somehow I think I was able to do it! https://github.com/jakepurple13/OtakuWorld/tree/no_firebase_variant That's the branch right now. I'll merge it either later today or tomorrow. This should also make it easier for others to help work on the app too since the no firebase variant doesn't need firebase.

jakepurple13 avatar Jun 21 '22 12:06 jakepurple13

Thanks! Testing.

linsui avatar Jun 21 '22 13:06 linsui

Also need to make sure the github actions pipeline still works with these changes.

jakepurple13 avatar Jun 21 '22 13:06 jakepurple13

There are some more non-free deps need to be striped:

  • gms
  • androidx.navigation:navigation-dynamic-features: it uses GMS to load dynamic functions.
  • mlkit
  • org.jetbrains.kotlinx:kotlinx-coroutines-play-services: it depends on GMS

linsui avatar Jun 21 '22 13:06 linsui

AH RIGHT! I added mlkit (which I thought is free), to translate descriptions

jakepurple13 avatar Jun 21 '22 13:06 jakepurple13

Sadly, most advance features provided by Google is not FOSS.

linsui avatar Jun 21 '22 13:06 linsui

Hm...I'll see what I can do then.

jakepurple13 avatar Jun 21 '22 13:06 jakepurple13

Thanks!

linsui avatar Jun 21 '22 13:06 linsui

I think it should be all good now.

jakepurple13 avatar Jun 21 '22 18:06 jakepurple13

I did merge it into develop by the way.

jakepurple13 avatar Jun 21 '22 18:06 jakepurple13

It works, thanks! It seems there are several different apps in this repo. Is com.programmersbox.otakuworld a unified app? Should I package all of them?

linsui avatar Jun 22 '22 03:06 linsui

There's three (technically four) apps in this project. AnimeWorld, AnimeWorld TV, MangaWorld, and NovelWorld. OtakuWorld WILL NOT work. It was an attempt at viewing favorites from all the other apps in one place but it didn't work out too well.

jakepurple13 avatar Jun 22 '22 09:06 jakepurple13

Got it! Thanks!

linsui avatar Jun 22 '22 09:06 linsui

AnimeWorld depends on com.google.android.exoplayer:extension-cast which depends on GMS. MangaWorld build failed:

> Task :mangaworld:processNoFirebaseReleaseResources FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':mangaworld:processNoFirebaseReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > Android resource linking failed
     ERROR:/builds/linsui/fdroiddata/build/com.programmersbox.mangaworld/mangaworld/src/main/res/layout/page_end_chapter_item.xml:9: AAPT: error: attribute adSize (aka com.programmersbox.mangaworld:adSize) not found.
         
     ERROR:/builds/linsui/fdroiddata/build/com.programmersbox.mangaworld/mangaworld/src/main/res/layout/page_end_chapter_item.xml:9: AAPT: error: attribute adUnitId (aka com.programmersbox.mangaworld:adUnitId) not found.
         
     ERROR:/builds/linsui/fdroiddata/build/com.programmersbox.mangaworld/mangaworld/src/main/res/layout/page_next_chapter_item.xml:8: AAPT: error: attribute adSize (aka com.programmersbox.mangaworld:adSize) not found.
         
     ERROR:/builds/linsui/fdroiddata/build/com.programmersbox.mangaworld/mangaworld/src/main/res/layout/page_next_chapter_item.xml:8: AAPT: error: attribute adUnitId (aka com.programmersbox.mangaworld:adUnitId) not found.
         
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org/
BUILD FAILED in 8m 6s

Could you please take a look? Thanks!

linsui avatar Jun 22 '22 12:06 linsui

Mmmm...That's annoying. Guess I have to limit the ads too then...Not like they were in the way! If you were wondering how could I do such a thing. They are SO out of the way, you kinda need to try to find them. But I can try something.

As for casting, that's really annoying. That would mean we won't be able to cast. I guess I can, but then need to make sure to explicitly point out that in the no firebase version, casting is not available.

jakepurple13 avatar Jun 22 '22 12:06 jakepurple13

Yes, there are many convenient functions provided by GMS and Firebase. Instead of remove all GMS from the flavor, we can also use https://github.com/microg/GmsCore.

linsui avatar Jun 22 '22 13:06 linsui