simple-page-ordering icon indicating copy to clipboard operation
simple-page-ordering copied to clipboard

Escape late rather than during building of query_string

Open phh opened this issue 7 years ago • 1 comments

To reproduce:

  • Go to pages
  • In the admin columns click an author (to show the authors posts)
  • Then click "Sort by order"
  • The filter is now broken as the url instead contains #038;
  • Replacing #038; with & fixes the filter

With this fix the filters just keep working.

phh avatar Mar 14 '17 09:03 phh

Hi @phh! Sorry we missed this - we had been working on migrating this plugin repo to the @10up organization account. Looks like an identical fix went in as https://github.com/10up/simple-page-ordering/pull/6 and was released to .org - I don't know if there's any way to get you GitHub contribution credit at this point without the unpleasantries of force-pushing but I'll look into it.

helen avatar Apr 02 '18 19:04 helen