simple-page-ordering icon indicating copy to clipboard operation
simple-page-ordering copied to clipboard

Unable to use Sort by Order for a custom post type and taxonomy

Open dylanjameswagner opened this issue 9 years ago • 2 comments

In the admin. When viewing a custom post type list by taxonomy the Sort by Order link is invalid, it includes an encoded ampersand, outputting #038; where an ampersand should be.

I believe the issue can be traced to line 284 of simple-page-ordering.php. There is a remove_query_arg wrapped by esc_url which I believe is encoding a trailing ampersand once the orderby and order have been removed.

I am able to restore expected functionality by removing the esc_url, but I am unsure of the security issues with doing so.

dylanjameswagner avatar Aug 19 '15 15:08 dylanjameswagner

Just made a PR #10 fixing this issue :)

timiwahalahti avatar Feb 01 '18 09:02 timiwahalahti

I believe this should be fixed in the latest .org release!

helen avatar Apr 02 '18 19:04 helen