Jacob MacDonald

500 errors for `*.ddc.js.errors` files prevents console logging of compilation errors

6

This looks like a side-effect of changing `canRead` to fail for "failed" assets. We fail the build step on compilation errors which means that we can't read the errors files...

build script change detection doesn't check parts

2

I noticed today that if you modify a part file that is imported by the build script we don't pick that up and invalidate the build.

DeepCollectionEquality is not symmetric most of the time

3

When comparing a List/Set to an Iterable, the order of the arguments will give a different result, making them non-symmetric. This actually varies on the implementation though - in the...

Consider changing UnionSetController constructor into a factory

1

See context here https://github.com/dart-lang/collection/pull/123/files/67f1b6438c3d7045b82dc6a14f0b988ab81c9e2f#r393273134 This would allow the `_set` field to be non-late in nnbd.

Logging into github breaks dartpad (possible race condition?)

15

## What happened? I noticed that dartpad now has github integration which is great, so I attempted to log in. When I clicked the button to log in, it eventually...

Console errors on each keystroke in the editor

4

## What happened? I am getting the following errors in the console whenever I type in DartPad: ``` playground.dart.js:455 Uncaught TypeError: Cannot read properties of null (reading 'toString') at fi.eS...

Question regarding the dev setup

1

Hi! I recently checkout out this repo to work on a quick bug fix, and I was wondering a bit about the dev setup. In particular, the `grind serve` task...

See https://github.com/google/mono_repo.dart/pull/198, which would add a `mono_repo travis --validate` option. Today it is clunky to configure - you have to add it to some random mono_pkg.yml file in the repo...

Support a default mono_pkg.yml for subpackages

5

Most of the packages in https://github.com/dart-lang/build want the exact same travis config (actually, all of them I think), but today they all need their own .travis.yml file. It would be...