cloudflare-purge-action icon indicating copy to clipboard operation
cloudflare-purge-action copied to clipboard

Move over entirely to the new Actions YAML syntax

Open chabad360 opened this issue 5 years ago • 8 comments

This PR almost entirely removes the need for the env section in the workflow config (now it's only needed for PURGE_URLS) and transfers everything over to the with section (see the modified readme for details).

chabad360 avatar Oct 13 '19 18:10 chabad360

Thanks @chabad360, this all looks good to me!

Unfortunately I'll need to hold off on merging because I had attempted to move the metadata from action.yml into Dockerfile in the past and it blocked me from publishing to the Action Marketplace.... Very, very weird but I sent a support ticket and have a thread on the forums (no response there yet) and I'll update you when I hear back from GitHub. Thanks again!!

jakejarvis avatar Oct 17 '19 20:10 jakejarvis

Yup, I discovered that the hard way too, turns out that as of last week the HCL (i.e. docker metadata) syntax is no longer supported (remember, Actions are after all only in beta). I had to migrate my Action as well (it was a pain, but now I feel almost like an expert in such migrations)...

But honestly, I really think the YAML format is better, it keeps things separate and cleaner...

chabad360 avatar Oct 17 '19 20:10 chabad360

If you don't mind, I'll post a more detailed response on that forum post soon

chabad360 avatar Oct 17 '19 21:10 chabad360

Sure thing! 👍

jakejarvis avatar Oct 17 '19 22:10 jakejarvis

So this can be merged then?

chabad360 avatar Oct 18 '19 22:10 chabad360

any update on if this can be merged?

chabad360 avatar Nov 26 '19 20:11 chabad360

@jakejarvis Sorry to be that guy, but "+1" couple of months since the last update is hopefully appropriate :)

I want to use this action, but env doesn't seem very natural in modern Actions.

Is there anything still preventing this PR from being merged?

RReverser avatar Jun 18 '20 12:06 RReverser