finatra-swagger icon indicating copy to clipboard operation
finatra-swagger copied to clipboard

Published 20 hours ago • verified publisher icon jakehschwartz

Cleaner interface

Open jakehschwartz opened this issue 7 years ago • 4 comments

Clean up the interface a bit:

  • Change SwaggerController to DocsController
  • Move controllers to controller package
  • More

jakehschwartz avatar Apr 25 '17 20:04 jakehschwartz

I don't like the fact that there are 2 controllers to import, will merge WebjarsController into DocsController

jakehschwartz avatar Apr 25 '17 23:04 jakehschwartz

Nevermind, I'll leave this for now

jakehschwartz avatar Apr 25 '17 23:04 jakehschwartz

Changed my mind again. The main bonuses are ease of use (only having 1 controller) and more Finatra like (having Swagger be managed through DI)

jakehschwartz avatar Apr 26 '17 22:04 jakehschwartz

This is cleaner than it was, but it would be nice not have to inject the Swagger object in all the controllers just so it can be assigned to an implicit.

jakehschwartz avatar May 09 '17 22:05 jakehschwartz