sassline icon indicating copy to clipboard operation
sassline copied to clipboard

Rename style.scss to something safer

Open TheJaredWilcurt opened this issue 8 years ago • 2 comments

If someone wants to use Bower to install Sassline, and then use bower_compents\sassline\assets\sass as a location to look for items being imported they'd have to use the generic @import "style" which is not very descriptive and would lend itself to importing in the wrong file from a different directory.

style.scss should be renamed to sassline.scss.

See how the following mixin libraries follow this same pattern:

Code Source
@import "buttons"; github.com/alexwolfe/Buttons
@import "saffron"; github.com/corporadobob/saffron
@import "sassmatic"; github.com/DarbyBrown/sassmatic
@import "scut"; github.com/davidtheclark/scut
@import "su"; github.com/ericam/susy
@import "susy"; github.com/ericam/susy
@import "susyone"; github.com/ericam/susy
@import "andy"; github.com/gillesbertaux/andy
@import "typesettings"; github.com/ianrose/typesettings
@import "animate"; github.com/Igosuki/compass-mixins
@import "compass"; github.com/Igosuki/compass-mixins
@import "lemonade"; github.com/Igosuki/compass-mixins
@import "style"; github.com/jakegiltsoff/sassline
@import "sassy-buttons"; github.com/jhardy/Sassy-Buttons
@import "bluebird"; github.com/kalebheitzman/bluebird
@import "sass-easing"; github.com/kingscooty/sass-easing
@import "breakpoint"; github.com/lesjames/breakpoint
@import "css3-mixins"; github.com/matthieua/sass-css3-mixins
@import "cssowl"; github.com/owl-stars/cssowl
@import "spice"; github.com/spice-sass/spice
@import "bourbon-deprecated-upcoming"; github.com/thoughtbot/bourbon
@import "bourbon"; github.com/thoughtbot/bourbon
@import "neat"; github.com/thoughtbot/neat

Since this may be a breaking change for those who explicitly targeted bower_compents\sassline\assets\sass\style.scss you should include a major version bump from v2.1.2 to v3.0.0.

TheJaredWilcurt avatar Mar 09 '16 21:03 TheJaredWilcurt

@TheJaredWilcurt I’ll think on this. This isn’t the direction I wanted to take the project, it is more of a boilerplate / starting point than an add-on unit. I can see the benefit of the route though.

jakegiltsoff avatar Mar 20 '16 18:03 jakegiltsoff

@jakegiltsoff I was just adding mixin libraries to Scout-App 2, and was going to include this one out of the box by default, but couldn't do it with "style" as the name.

If it isn't meant to be used as a dependency I can just remove it from the list.

TheJaredWilcurt avatar Mar 21 '16 00:03 TheJaredWilcurt