Jake Donham comments

Results 19 comments of


                                            Jake Donham

Compiler crashes when setter/getter is called

Oh, also, it is difficult to give a good error message here because we are working with the lambda code, which no longer contains source locations. But it could probably...

Compiler crashes when setter/getter is called

Yes, overapplication of a setter should be a type error, but we must know the type of the setter. If you write ``` class type foo = object method _set_x...

max_int, min_int and min_float do not have the correct values

Thank you for the bug report. See the following commit for some discussion on this issue: https://github.com/dsheets/ocamljs/commit/7bb091f306c93f70bf6e70fe481a38efd71dda5b I am inclined to set min_int and max_int to the proper values for...

Will you support web components instead of JSX?

hi, thanks for getting in touch! The Blocks app uses React, but it communicates with individual blocks using iframes and message passing, so there is no inherent reason that Blocks...

Markdown block breaks for some syntax

huh does the new Markdown-edit block use something other than MDX to render pages? I would expect to see the same bug otherwise.

Markdown block breaks for some syntax

whoa! gotta read that code

feat: use new `buildTree` utility function

another thought here: should we consider changing the Blocks API so file trees are passed in a more useful way? rather than needing a library function in the block

UnderlineNav doesn't update its tabs when the items change

Thanks @camertron / @lesliecdubs. We're using it in a tabbed file editor, where files can be added / removed / renamed.

UnderlineNav doesn't update its tabs when the items change

This is for a GitHub Next prototype called GitHub Spark. Tagging @drifkin for followup.