NotifyMe icon indicating copy to clipboard operation
NotifyMe copied to clipboard

Question: What does "dismiss" and "done" button exactly do?

Open maxx2478 opened this issue 4 years ago • 6 comments

First of all I request developer to add wakelock to the library.

And, after implementation, I noticed If I click on "done" the daily notification stops, but not in the case of clicking "dismiss".

Kindly tell me what does these buttons exactly do.

Thanks for the library !

maxx2478 avatar Aug 14 '20 04:08 maxx2478

The "done" button was implemented like a delete or completed action. So it removes the notification from the local database, while the "dismiss" action is just used to close that instance of the notification and leave the future reoccurring ones. I'll look into adding wakelock option for those that need it!

jakebonk avatar Aug 15 '20 01:08 jakebonk

Thank you so much for information.

BTW, yesterday I added wakelock for one line code in NotificationPublisher.class, i.e.

 if (wakeLock != null)
      wakeLock.acquire(10000);

      mNotificationManager.notify(Integer.parseInt(notificationId), notification);

if (wakeLock != null)
      wakeLock.release();

The notification pops up, but at wrong time... I'd set time as 8.00am but it popped up at 9am.

I'm not sure what to do to fix this.

maxx2478 avatar Aug 15 '20 12:08 maxx2478

I haven't worked with wakelock before so I'll test it a bit this weekend but I looked at the documentation and wouldn't calling wakeLock.release(); cancel the wakelock? So you would have to call wakelock.release() after the notification was received?

Also was it exactly 1 hour or was it off a bit?

jakebonk avatar Aug 15 '20 13:08 jakebonk

Exactly after 1 hour @9am.

Now I've added wakelock for whole Notification code, I'll test again for 2-3 days and see if I've did right implementation of Wakelock.

maxx2478 avatar Aug 15 '20 16:08 maxx2478

I played around with for a bit and I couldn't get it to miss the correct time. What timezone are you using?

jakebonk avatar Aug 17 '20 14:08 jakebonk

I'm using GMT +05.30

maxx2478 avatar Aug 17 '20 16:08 maxx2478