Jake Bailey
Jake Bailey
Nope, I asked for a merge because we added some new required CI checks that weren't present on the branch the last time CI ran.
Agh, pack this doesn't work on release branches, since their versions have already been set.
@typescript-bot test it I guess I should make that an alias, as two people have done that today...
6 new errors in vscode based on the benchmarks; it's confusing why the user tests did not say anything there, but maybe top400 will say something.
Tested manually: ``` src/vs/base/common/path.ts:335:4 - error TS2869: Truthiness test of this kind of expression appears unintentional 335 `${resolvedDevice}${resolvedTail}` || '.'; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/vs/editor/standalone/test/browser/monarch.test.ts:236:24 - error TS2869: Truthiness test of this kind...
Yep, though given the full code is: ```js case "number": if (typeof value === "number") return value; if (typeof value === "string" && /^[+-]?\d*(\.\d*)[eE]\d+$/) { const n = +value; if...
@typescript-bot test it @typescript-bot pack this
Hm, real perf is worse (duh), but moreso it's interesting that there are more symbols and types in the perf tests.
Closing; if I want to retest this I'll repick from the `tsgo-port` branch with both sorting changes.
This is an incredibly popular package; 12.8 million weekly downloads. There are also a load of packages within DT which depend on `@types/tough-cookie`, unfortunately the DT infra is not smart...