Jake Bailey
Jake Bailey
Things should have improved here, can you retest?
I don't see the crash, but it does emit a bunch of errors: ``` ... ~~~~~~~~~~~~~~~~~~~~~~~ node_modules/chai/chai.js:1380:30 - An argument for 'ssfi' was not provided. 1380 function Assertion(obj, msg, ssfi,...
Oddly, this one chai file is added to the program in tsgo, but not in tsc.
I feel like this must be a module resolution bug. I added some extra logging, and: ``` In /home/jabaile/work/repros/tsgo931/node_modules/vitest/dist/config.d.ts resolved module chai to /home/jabaile/work/repros/tsgo931/node_modules/chai/chai.js with mode ModuleKindESNext In /home/jabaile/work/repros/tsgo931/node_modules/vitest/dist/chunks/reporters.d.C-cu31ET.d.ts resolved...
I guess it could just be that. I was assuming that because this is a "real" project that the depth thing has nothing to do with it.
Huh, no, I'm just wrong. The code really doesn't care, it's just that we set it to zero normally. I'll try and port that code quick.
The concurrency makes this not simple, who would have guessed.
@LukeAbby Can you try #1189 out? I believe it fixes your problem. ```console $ tsgo --listFilesOnly | grep chai /home/jabaile/work/repros/tsgo931/node_modules/@vitest/expect/dist/chai.d.cts $ tsgo --listFilesOnly --maxNodeModuleJsDepth 1 | grep chai /home/jabaile/work/repros/tsgo931/node_modules/@vitest/expect/dist/chai.d.cts /home/jabaile/work/repros/tsgo931/node_modules/chai/chai.js...
Then again: ```console $ npx tsc --listFilesOnly | grep chai /home/jabaile/work/repros/tsgo931/node_modules/@vitest/expect/dist/chai.d.cts $ npx tsc --listFilesOnly --maxNodeModuleJsDepth 1 | grep chai /home/jabaile/work/repros/tsgo931/node_modules/@vitest/expect/dist/chai.d.cts ``` So, maybe not quite perfect yet (but seemingly...
Fixed the above discrepency in the PR: ```console $ for i in $(seq 0 5); do echo "depth=$i tsgo"; ~/work/TypeScript-go/built/local/tsgo --listFilesOnly --maxNodeModuleJsDepth $i | grep chai; echo "depth=$i tsc"; npx...