Jake Bailey

Results 1482 comments of Jake Bailey

@Renegade334 are you satisfied with the changes so far?

CI has to pass for this to go in, yes; the other packages have to be updated to pass. This also may be an indicator that this sort of change...

If you are able to build and reproduce it, it would be helpful if you could bisect the problem (since we don't have any other info to go on from...

If you want to hack it locally, just replace `os.Stderr` in the LSP main function with `io.Discard`.

Yeah, I think it's causing VS Code to freeze sometimes too: ![Image](https://github.com/user-attachments/assets/0f7399af-ae71-48e8-8ede-5195abe8a5bc) ![Image](https://github.com/user-attachments/assets/58c983ba-4f99-43ca-9e4a-172ab7c5fd21)

I don't think I'm misunderstanding `which`. I'm referring to `which` in terms of the npm package's behavior, which handles `PATHEXT`. That can be manually implemented for sure, but it's certainly...

See also: https://github.com/npm/node-which/blob/b8d11c791296a3baf44703352619621215189b0e/lib/index.js#L31-L39

> That is not the intended usage of which as documented The code in `which` has this case explicitly supported: ``` // If it has a slash, then we don't...

Yes, I would expect that you could simply write (psuedocodeish): ```ts import path from "path"; import which from "which"; function getCmd(cmd: string, gopathBin: string | undefined, gobin: string | undefined):...