Jake Bailey

Results 1420 comments of Jake Bailey

This is a bit of a drive-by, but I tried this PR out in hopes it would fix #502; I get loads of these messages: ``` [MCR] failed to parse...

Well, the output coverage is a little... weird: ![image](https://github.com/bcoe/c8/assets/5341706/d1391224-9594-4c54-a25a-560b2aa1c6b4)

> Can you provide a small repo which reproduces your issue? Perhaps I can help fix it. I'm afraid I don't have a small repo; I'm running this on TypeScript...

Thanks! I didn't test with `mcr` directly, just this PR again, and it all seems to be working from what I can tell. Looking forward to having something that works.

See also #34, #325. I ended up converting my entire codebase to explicitly pass in dependencies I wanted to mock and giving up on things like rewire, esmock for this...

Kat is a team member, no need to be hasty 🙂

This all should be done in nightly, so I would just use that. But you'll find a permanent npm version in the comment below the pipelines tgz anyway.

Please file a new issue with your repro.

TS 5.5 is coming out this week, so I wouldn't think we'd be patching 5.4 anymore.

https://github.com/nodejs/node/pull/52762 was merged a bit ago; I should be able to retarget this PR at nightly.