Jake Bailey
Jake Bailey
Perf of this is still pretty bad. A lint run on main in CI takes about 30s, but on this branch takes 4m44s.
This is fixed!
I feel like we wanted to eliminate this feature entirely, actually
Do you have the rest of the code that triggers this difference? (Probably, this is #1603?)
Do you know what version between those fixed it? Not sure we changed something on this front
So, it's fixed? 😄
That's not implemented yet. What does this have to do with your empty string panic?
It's been a month and there hasn't been a repro provided. We can't really do anything without something to test.
Multi-line binary expression in call args causes closing paren to be placed on same line as last arg
Indeed, I'm just trying to close the loop on all of the "oddities" on the TS PR before we merge it and forget about them.
Can you update `tests/cases/compiler/APILibCheck.ts` and enable this flag? This would let us ensure our public API will work with this flag; we already do this for `exactOptionalPropertyTypes`.