Jake Archibald
Jake Archibald
@getify it's kinda nice that one function could do both, but I'm worried it muddies the intent of the method. `abortableTask(signal, callback)` is designed as a best practice way to...
@benjamingr it comes from `EventTarget`. It would seem weird for it to behave differently to every other event on the platform. Also, it'd confuse how to remove listeners.
I'm not sure how to interpret the lighthouse failure here.
I haven't tested this btw, so it'll need an eyeball to check that it works with existing video content.
@rachelandrew this is ready for review and landing. The CLA check is failing due to @domenic, but he's a Googler so I presume it's fine?
Is there anything I need to do before this can be reviewed and merged?
> I just missed the original message (feel free to ping me on Chat if I'm ignoring something). I'll take a look now. Shall do! Didn't want to hassle you....
A same-same-but-different issue: If source files contain `/* Super amazing copyright 2019 */`, and that's changed to `2020`, this will cause Rollup to change the hash of all files, even...
Unless I missed something on a skim-read, that's still relying on Rollup to do the right thing with regard to hash cascading right? If Rollup gets it wrong, your result...
Hm, maybe we need to clarify on the test a bit. A solution to this problem shouldn't break the hash cascading https://bundlers.tooling.report/hashing/js-entry-cascade/.