Status should be an enum

[gavinking]

Java has had enum for, well—I don't recall exactly—but all of the current millennium, I guess. Until quite recently, enums weren't especially worth the effort because the Java compiler treated them in a pretty stupid way, but recent version of the Java language finally introduce proper coverage analysis in switch expressions, making enum actually useful for something.

JTA's Status is an artifact preserved in ice from the glory days of J2EE, before the existence of enum, and is defined in terms of magical ints. The compiler can never hope to do coverage analysis for Status.

(Another much smaller problem with this class is that it's one of about eleventy-billion top-level classes named Status in a typical Java program.)

I therefore propose introducing an enum with a name like TransactionStatus or Transaction.Status, and deprecating the ints. I hope this is not too radical a proposal in the year of our lord 2025.