transactions icon indicating copy to clipboard operation
transactions copied to clipboard

[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor

Open ochaloup opened this issue 3 years ago • 7 comments

fixes #191

ochaloup avatar Apr 22 '21 07:04 ochaloup

Can one of the admins verify this patch?

jta-bot avatar Apr 22 '21 07:04 jta-bot

OK to test

tomjenkinson avatar Apr 22 '21 11:04 tomjenkinson

@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed?

tomjenkinson avatar Apr 22 '21 11:04 tomjenkinson

@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change?

The test would be to:

  • Verify that an @Transactional annotated bean that throws an java.lang.Error will result in the transaction being marked for rollback? *Verify that an @Transactional annotated bean which is declared to rollbackOn SQLException (and not SQLWarning) and that throws an Error in one of the relevant methods does actually cause the transaction to be marked for rollback?

This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional

tomjenkinson avatar Sep 17 '21 11:09 tomjenkinson

@tomjenkinson sure, I know. I will try to create the tests in TCK.

ochaloup avatar Sep 17 '21 13:09 ochaloup

retest this please

tomjenkinson avatar Sep 24 '21 11:09 tomjenkinson

retest this please

tomjenkinson avatar Dec 06 '21 17:12 tomjenkinson