transactions
transactions copied to clipboard
[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor
fixes #191
Can one of the admins verify this patch?
OK to test
@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed?
@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change?
The test would be to:
- Verify that an
@Transactional
annotated bean that throws an java.lang.Error will result in the transaction being marked for rollback? *Verify that an@Transactional
annotated bean which is declared to rollbackOnSQLException
(and notSQLWarning
) and that throws anError
in one of the relevant methods does actually cause the transaction to be marked for rollback?
This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional
@tomjenkinson sure, I know. I will try to create the tests in TCK.
retest this please
retest this please