specifications icon indicating copy to clipboard operation
specifications copied to clipboard

feat: Add content to Concurrency Spec page

Open ZacharySabourin opened this issue 2 years ago • 8 comments

Resolves https://github.com/jakartaee/jakarta.ee/issues/1748

ZacharySabourin avatar Dec 15 '23 19:12 ZacharySabourin

Deploy Preview for jakartaee-specifications ready!

Name Link
Latest commit 6b15a643c51dc481e7c396d9e79d44240054dd60
Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/658359e30190240008e39f0f
Deploy Preview https://deploy-preview-685--jakartaee-specifications.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 15 '23 19:12 netlify[bot]

@chrisguindon

ZacharySabourin avatar Dec 15 '23 20:12 ZacharySabourin

@ivargrimstad Preview page: https://deploy-preview-685--jakartaee-specifications.netlify.app/specifications/concurrency/

ZacharySabourin avatar Dec 18 '23 15:12 ZacharySabourin

Request for the Project team to review: https://www.eclipse.org/lists/cu-dev/msg00467.html

ivargrimstad avatar Dec 20 '23 15:12 ivargrimstad

My review comments above assume a level of Jakarta EE 10. In Jakarta EE 11, it will also be possible to use CDI to obtain the resources that provided by the Concurrency specification.

njr-11 avatar Dec 20 '23 16:12 njr-11

@njr-11 I've made some modifications based on your feedback. Let me know what you think!

ZacharySabourin avatar Dec 20 '23 19:12 ZacharySabourin

@njr-11 @ivargrimstad Are we good to go with this page, or are there more project team members expected to review?

ZacharySabourin avatar Dec 21 '23 14:12 ZacharySabourin

@ZacharySabourin I'm fine with it, but I cannot say whether or not others will be interested in reviewing it as well. Maybe check with @smillidge who is the spec lead?

njr-11 avatar Dec 21 '23 15:12 njr-11