specifications icon indicating copy to clipboard operation
specifications copied to clipboard

Minor typo fix

Open mehdirahimi opened this issue 2 years ago • 4 comments

Minor typo fix Fages to Pages.

mehdirahimi avatar Jun 01 '22 04:06 mehdirahimi

Deploy Preview for jakartaee-specifications ready!

Name Link
Latest commit 263de530136006bd50be04814c2f6a7d1140a08e
Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/6296e4431dab960008e3d10c
Deploy Preview https://deploy-preview-504--jakartaee-specifications.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 01 '22 04:06 netlify[bot]

Thanks for this!

It would be best though to make this change in the source project, which is at eclipse-ee4j/mojarra.

arjantijms avatar Jun 01 '22 09:06 arjantijms

Thanks for this!

It would be best though to make this change in the source project, which is at eclipse-ee4j/mojarra.

I couldn't find equivalent path of this change (faces/2.3/apidocs/javax/faces/webapp/FacesServlet.html) in eclipse-ee4j/mojarra project. Could you please tell me where is it?

mehdirahimi avatar Jun 01 '22 12:06 mehdirahimi

Faces Servlet in master is here:

https://github.com/eclipse-ee4j/mojarra/blob/master/impl/src/main/java/jakarta/faces/webapp/FacesServlet.java

The 2.3 version is here:

https://github.com/eclipse-ee4j/mojarra/blob/2.3/impl/src/main/java/javax/faces/webapp/FacesServlet.java

You do need to accept the ECA so we can accept contributions. That entails creating an Eclipse account with the same email you used for committing, and then make sure you have the green checkbox in your account as here: https://accounts.eclipse.org/users/atijmse7y (see top right)

arjantijms avatar Jun 01 '22 13:06 arjantijms

For Faces. Closing here.

ivargrimstad avatar Jul 24 '23 10:07 ivargrimstad