security icon indicating copy to clipboard operation
security copied to clipboard

[TCK Challenge] Ignore ee.jakarta.tck.security.test.AppMemBasicDecorateIT.testNotAuthenticatedAndDecorated()

Open darranl opened this issue 3 years ago • 7 comments

Following on the discussions under the issue https://github.com/jakartaee/security/issues/267 and related approved PR https://github.com/jakartaee/security/pull/268 I am raising this challenge to request the ability to ignore the results of the following test whilst using version 3.0.0 of the Jakarta Security TCK:

ee.jakarta.tck.security.test.AppMemBasicDecorateIT.testNotAuthenticatedAndDecorated()

darranl avatar Aug 26 '22 15:08 darranl

This challenge should also include ee.jakarta.tck.security.test.AppMemBasicDecorateIT.testAuthenticated(). This test fails for the same reason as ee.jakarta.tck.security.test.AppMemBasicDecorateIT.testNotAuthenticatedAndDecorated().

fjuma avatar Aug 29 '22 15:08 fjuma

Please find attached the failure details from the app-mem-basic-decorate module run against current WildFly main:

Issue_270_details.zip

bstansberry avatar Aug 29 '22 15:08 bstansberry

It's somewhat controversial whether the code that the test uses internally is actually illegal, but since its an internal detail and totally not relevant to what the test is actually testing the test has indeed been adjusted.

Since the ability to decorate is rather important and we have no other test coverage for this, I'd like to propose asking for an exception first to include the updated test in a revision of the TCK.

Thoughts?

arjantijms avatar Aug 29 '22 18:08 arjantijms

It depends on timing. We are close to being able to send up CCRs, so we filed this challenge to avoid blocking that.

The EE 10 Full Platform and Web Profile ballots have started so the urgency of WildFly trying to file CCRs before that happened is gone. So a delay of a couple days should be fine, but if it's going to take a while and this becomes the only blocking issue I'd like to see this accepted.

bstansberry avatar Aug 30 '22 12:08 bstansberry

@bstansberry good point, I see the concern.

I'll bring it up in the platform meeting today, and see if a vote can be organised in a couple of days. If not I'll accept the challenge and then the test will very likely be part of at least EE 11 again.

arjantijms avatar Aug 30 '22 14:08 arjantijms

Is there a reason why this challenge hasn't been labeled as accepted yet?

Since the ability to decorate is rather important and we have no other test coverage for this, I'd like to propose asking for an exception first to include the updated test in a revision of the TCK.

I suggest that we label it as accepted (if it is) and state whether users can workaround the challenge by excluding the two tests. If that workaround is not accepted, we should change the tests I think.

FYI https://github.com/jakartaee/jakarta.ee/pull/1517 is for updating the TCK Process.

scottmarlow avatar Nov 09 '22 19:11 scottmarlow

This challenge impacts Open Liberty, so we are also eager to see a resolution here.

brideck avatar Nov 11 '22 20:11 brideck

Hi @arjantijms, Please let us know if this challenge has been accepted or if more information is needed.

Regards, Teddy

teddyjtorres avatar Nov 28 '22 18:11 teddyjtorres

We had apparently forgotten to merge this back in August / September, but it's merged now. This should conclude the challenge.

arjantijms avatar Dec 02 '22 21:12 arjantijms