persistence icon indicating copy to clipboard operation
persistence copied to clipboard

incorrect generic signature of From.join(String)

Open lukasj opened this issue 7 years ago • 4 comments

For example,

Form<Z,X>

      <Y> Join<X,Y> join(SingularAttribute<? superX,Y> attribute)
      <X,Y> Join<X,Y>  join(String attributeName);

For the 2nd method, why does the method <X> hide class <X>. It is not clear from javadoc. Need to explain why the join's source type is not the target type of the From.

lukasj avatar Sep 01 '17 22:09 lukasj

  • Issue Imported From: https://github.com/javaee/jpa-spec/issues/158
  • Original Issue Raised By:@javaone199
  • Original Issue Assigned To: Unassigned

lukasj avatar Aug 31 '18 16:08 lukasj

This looks like a good candidate for a community/end-user contribution. I would suggest marking it with "good first issue" and/or "help wanted". That will help facilitate recruiting people to contribute. I would honestly also mark this low priority.

Reza Rahman Jakarta EE Ambassador, Author, Blogger, Speaker

Please note views expressed here are my own as an individual community member and do not reflect the views of my employer.

m-reza-rahman avatar Apr 28 '21 17:04 m-reza-rahman

This is a bug, the method <X,Y> Join<X,Y> join(String attributeName); should be <Y> Join<X,Y> join(String attributeName); instead.

Unfortunately such change is backward incompatible, so unless there is a will or support from other implementations to fix this in a minor release, this will have to wait till major one.

lukasj avatar Dec 02 '21 14:12 lukasj

This is a bug, the method <X,Y> Join<X,Y> join(String attributeName); should be <Y> Join<X,Y> join(String attributeName); instead.

I agree. We should fix this in the next major version.

gavinking avatar Apr 13 '23 20:04 gavinking