mail-api icon indicating copy to clipboard operation
mail-api copied to clipboard

Multipart performs blocking call in every instantiation #699

Open jbescos opened this issue 1 year ago • 5 comments

https://github.com/jakartaee/mail-api/issues/699

It will try to get the StreamProvider from the session of the Message.

jbescos avatar Mar 04 '24 09:03 jbescos

@jmehrens I am redesigning it, because I found more usages of StreamProvider. I moved the getStreamProvider to the Part interface.

jbescos avatar Mar 06 '24 08:03 jbescos

Need to add entry to https://github.com/jakartaee/mail-api/blob/master/doc/release/CHANGES.txt

jmehrens avatar Mar 07 '24 06:03 jmehrens

Need to add entry to https://github.com/jakartaee/mail-api/blob/master/doc/release/CHANGES.txt

Done

jbescos avatar Mar 07 '24 08:03 jbescos

Lets wait for @lukasj review too. My impression is this requires the new version 2.2.0, and we will need other PR before to upgrade to that version.

jbescos avatar Mar 07 '24 08:03 jbescos

Side note: we'll have to review some of the Angus packages that also extend the classes here. DSN is an example. I glossed over it and I think it is a case of no changes need but something we should keep an eye on.

jmehrens avatar Mar 08 '24 07:03 jmehrens