mail-api icon indicating copy to clipboard operation
mail-api copied to clipboard

Published 20 hours ago • verified publisher icon jakartaee

Allow to override internal static fields

Open jbescos opened this issue 3 years ago • 2 comments

I have closed this PR https://github.com/eclipse-ee4j/mail/pull/515 and address it in this new PR. This is because of the conflicts after the split of API and Implementation.

jbescos avatar Aug 27 '21 09:08 jbescos

Notice that these changes breaks the TCK and I created a PR for that: https://github.com/eclipse-ee4j/mail-tck/pull/24

It is about setting the system property at the begging of the test.

As mail-tck is going to dramatically change here: https://github.com/eclipse-ee4j/mail-tck/pull/29 I suggest to wait for that to be merged. Then, I will create a new PR to update a couple of tests (setFileNameTest_encodeTrue_decodeFalse and setFileNameTest_encodeFalse_decodeTrue) to set the system property at the beggining. And finally, we can merge this.

jbescos avatar Sep 08 '21 07:09 jbescos

Setting this as a draft meanwhile this comment is not implemented: https://github.com/jakartaee/mail-api/pull/578#pullrequestreview-1231115312

jbescos avatar Jan 03 '23 09:01 jbescos