jsonb-api icon indicating copy to clipboard operation
jsonb-api copied to clipboard

Published 20 hours ago • verified publisher icon jakartaee

Fixed doc typos re: @Jsonb(De)Serializer

Open mkarg opened this issue 5 years ago • 5 comments

Partial fix of #70 (JavaDocs only)

Unfortunately I could only fix the JavaDocs, as there is just boilerplate for the actual spec.

mkarg avatar Aug 21 '19 09:08 mkarg

I marked this PR as a draft, as the spec source is not contained. Please tell me if I shall keep it in draft state until the spec source is available, or whether I shall turn it in a real PR so you could merge it. Thanks. :-)

mkarg avatar Aug 21 '19 09:08 mkarg

hi @mkarg thanks for the PR! I agree it would be good to update the spec doc at the same time as the javadoc so we don't lose track and the spec and javadoc become inconsistent with each other.

@m0mus do we have an ETA on when the real spec doc will be available on this repo?

aguibert avatar Aug 27 '19 15:08 aguibert

@aguibert You better ask Eclipse folks. They need to do some legal checks before allowing us using the old spec text.

m0mus avatar Aug 27 '19 16:08 m0mus

@m0mus Did EF already ask you for your approval of the spec? I was asked weeks ago and it seems nothing happend so far.

So how to proceed? Keep the PR in draft state until we have the OK from the EF, or merge this PR, keep the issue open, and create another PR for the spec change?

mkarg avatar Aug 27 '19 18:08 mkarg

@mkarg No, I didn't have any request from EF regarding the spec. I suppose that it will happen after Jakarta EE 8 release.

m0mus avatar Aug 28 '19 10:08 m0mus