faces icon indicating copy to clipboard operation
faces copied to clipboard

Published 20 hours ago • verified publisher icon jakartaee

Unify NavigationHandler and ConfigurableNavigationHandler

Open tandraschko opened this issue 1 year ago • 6 comments

why was it introduced? backward compatibility?

tandraschko avatar Jul 27 '23 13:07 tandraschko

Looks like so. A whole new class for this doesn't seem to be necessary. It could have implemented default behavior. E.g. simply returning null or delegating to existing method or throwing UnsupportedOperationException.

BalusC avatar Oct 01 '23 15:10 BalusC

Yep exactly

tandraschko avatar Oct 02 '23 08:10 tandraschko

I moved now all methods from ConfigurableNavigationHandler to NavigationHandler and marked ConfigurableNavigationHandler + Wrapper als Deprecated

tandraschko avatar Jun 27 '24 07:06 tandraschko

https://github.com/apache/myfaces/commit/f06506b5d644539080507f29667e4e0f8de86cdb

tandraschko avatar Jun 27 '24 07:06 tandraschko

should we make the abstract methods just return null or empty collection?

tandraschko avatar Jun 27 '24 08:06 tandraschko

fixed backward compatibility with PF: https://github.com/apache/myfaces/commit/edb58a9f41a7bd3a891bc596a40226e2d3178920

tandraschko avatar Jul 05 '24 13:07 tandraschko