faces icon indicating copy to clipboard operation
faces copied to clipboard

Remove injection and lookups for raw maps according to challenge #1710

Open arjantijms opened this issue 2 years ago • 1 comments

Fixes #1710

Signed-off-by: Arjan Tijms [email protected]

arjantijms avatar Nov 15 '22 15:11 arjantijms

It's also worth pointing out that the ApplicationMap test (both faces23 and faces40) are verifying behavior using the Mojarra-specific property jakarta.faces.BEANS_VALIDATION_AVAILABLE, which won't work for us. Can that be fixed here, too?

Alternatively, I could add it to the challenge for implementation-specific grievances (https://github.com/jakartaee/faces/issues/1703). Or if it's preferred, I can open a new challenge for additional implementation-specific grievances.

brideck avatar Nov 16 '22 17:11 brideck

Map<String, String> headerMap = CDI.current().select(new TypeLiteral<Map<String, String>>() {}, HeaderMap.Literal.INSTANCE).get();

In a way for usability this is quite a step back, but a logical consequence of not allowing raw maps indeed. Maybe we can introduce something like a HeaderMap.TYPE to represent new TypeLiteral<Map<String, String>>() {} for Faces.Next.

arjantijms avatar Nov 23 '22 12:11 arjantijms