faces icon indicating copy to clipboard operation
faces copied to clipboard

TCK Challenge: old-tck application(Wrapper)GetExpressionFactoryTest uses wrong control case

Open brideck opened this issue 3 years ago • 3 comments

Challenged Tests: com.sun.ts.tests.jsf.api.jakarta_faces.application.application.URLClient#applicationGetExpressionFactoryTest com.sun.ts.tests.jsf.api.jakarta_faces.application.applicationwrapper.URLClient#applicationWrapperGetExpressionFactoryTest

TCK Version: Jakarta Faces 4.0.x

Tested Implementation: Open Liberty -- containing MyFaces 4.0

Description: In the Javadoc for Jakarta Faces 3.0, Application.getExpressionFactory() it is specified that "The implementation must return the ExpressionFactory from the Jakarta Server Pages container by calling JspFactory.getDefaultFactory().getJspApplicationContext(servletContext).getExpressionFactory()."

For Jakarta Faces 4.0, this was updated to read "The implementation must return the ExpressionFactory from the Expression Language container by calling jakarta.el.ELManager.getExpressionFactory(). " However, the control case in the the challenged tests was not updated to match the newly specified behavior.

brideck avatar Nov 10 '22 23:11 brideck

This is valid from my perspective. @BalusC @arjantijms what do you think?

pnicolucci avatar Nov 15 '22 13:11 pnicolucci

+1

BalusC avatar Nov 16 '22 20:11 BalusC

@arjantijms any objection to accepting this one?

pnicolucci avatar Nov 21 '22 13:11 pnicolucci

@arjantijms can you take a look at this? Thanks!

Emily-Jiang avatar Nov 23 '22 22:11 Emily-Jiang