faces icon indicating copy to clipboard operation
faces copied to clipboard

Add new FacesMessage Severity "SUCCESS"

Open chsreedhar opened this issue 4 years ago • 20 comments

Adding a "success" severity for FacesMessages sounds like a good idea to me.

There is an issue of JavaServer Faces Add new FacesMessage Severity "SUCCESS" eclipse-ee4j/mojarra#895 and it is closed.

FacesMessages, <b:messages /> & <b:message /> eclipse-ee4j/mojarra#1000

chsreedhar avatar Apr 30 '20 04:04 chsreedhar

This would be a good first stepping stone, before allowing custom faces messages.

elasticondo avatar Jun 08 '20 13:06 elasticondo

would like to do this for 4.1; easy and good enhancement

tandraschko avatar Feb 23 '23 10:02 tandraschko

+1 for the idea.

Put it between INFO and WARN.

Bump of ordinals of WARN and higher will however affect backwards compatibility on those who are comparing them with hardcoded integers.

Nonetheless, I also strongly feel like we should migrate the whole Severity class to a normal enum. The same for PhaseId. Is there more? This is better to be done in 5.0 rather than 4.1.

BalusC avatar Feb 23 '23 12:02 BalusC

+1 for enums

tandraschko avatar Feb 23 '23 13:02 tandraschko

move to 5.0 and refactor to enum

tandraschko avatar Feb 25 '23 17:02 tandraschko

will only handle the new sucess here and moved the enum change to a own ticket

tandraschko avatar Jun 26 '24 13:06 tandraschko

See: https://github.com/apache/myfaces/commit/3b690139243194e48a0557d9dd0a21f0d5b7af01

tandraschko avatar Jun 26 '24 14:06 tandraschko