faces
faces copied to clipboard
Add new FacesMessage Severity "SUCCESS"
Adding a "success" severity for FacesMessages
sounds like a good idea to me.
There is an issue of JavaServer Faces Add new FacesMessage Severity "SUCCESS" eclipse-ee4j/mojarra#895 and it is closed.
FacesMessages, <b:messages /> & <b:message /> eclipse-ee4j/mojarra#1000
This would be a good first stepping stone, before allowing custom faces messages.
would like to do this for 4.1; easy and good enhancement
+1 for the idea.
Put it between INFO and WARN.
Bump of ordinals of WARN and higher will however affect backwards compatibility on those who are comparing them with hardcoded integers.
Nonetheless, I also strongly feel like we should migrate the whole Severity class to a normal enum. The same for PhaseId. Is there more? This is better to be done in 5.0 rather than 4.1.
+1 for enums
move to 5.0 and refactor to enum
will only handle the new sucess here and moved the enum change to a own ticket
See: https://github.com/apache/myfaces/commit/3b690139243194e48a0557d9dd0a21f0d5b7af01