faces
faces copied to clipboard
jakartaee
importConstants should be allowed everywhere, not only in f:metadata
In big and modular applications, it's to complex to import all enums via f:metadata. Every CC or include should be able to maintain their own imports, otherwise its very hard to maintain.
- Issue Imported From: https://github.com/javaee/javaserverfaces-spec/issues/1466
- Original Issue Raised By:@tandraschko
- Original Issue Assigned To: Unassigned
@BalusC Commented
Agreed and this is also how <o:importConstants> behaves, but the 2.3 EG decided so.
@tandraschko Commented I see :/ But we could talk about it again for the next version, right?
Should this be a general f:metadata revsion? Nice if the spec could be updated to handle https://github.com/eclipse-ee4j/mojarra/issues/5105
The omnifaces documentation lists that the o:importConstants saves the objects in the request scope. Should this approach also be taken by the spec / impls?
Few questions:
-
Should ViewMetadata#getImportConstants change or should it still return the list of import constants?
-
Should this tag keep the same taglib uri (jakarta.faces.core) and just simply be allowed to be placed anywhere? Or should a new tag be created?
Let's move to 5.0 for now. We can then take the opportunity to reconsider the f:metadata. Also related: https://github.com/jakartaee/faces/issues/1849
