concurrency icon indicating copy to clipboard operation
concurrency copied to clipboard

Published 20 hours ago • verified publisher icon jakartaee

Add tests for ManagedThreadFactory Injected to Servlet

Open aubi opened this issue 1 year ago • 2 comments

aubi avatar Feb 05 '24 13:02 aubi

As I commented on https://github.com/jakartaee/concurrency/pull/212, I cannot support it. I believe behavior has never been clearly specified in the spec. GlassFish, which used to be the reference impl doesn’t comply with it.

I’d like to see opinions from other implementors and users of other implementations before I and the GlassFish team can support this.

OndroMih avatar Feb 05 '24 21:02 OndroMih

@njr-11 Thanks a lot for your comments! I'll fix the issues.

@OndroMih

  1. I think that injection is the preferred way of using MES etc. So having some tests makes sense.
  2. Regarding the issue with storing context -- this test shows, what exactly I meant and I would like to clarify, how it should behave. But I'll fix the Nathan's issues first.

aubi avatar Feb 06 '24 16:02 aubi