concurrency icon indicating copy to clipboard operation
concurrency copied to clipboard

TCK jar test code source and consistent totals of results

Open njr-11 opened this issue 2 years ago • 0 comments

Comments on the release review of Concurrency 3.0 from @edbratt that we can address in the following release:

I did notice that the TCK JAR does not contain test source-code. This is not strictly a requirement so I won't hold this up further but please create a GitHub release or tag so that the test sources are readily obtainable. If you are also pushing artifacts to Maven, probably you are already generating a source jar. (I guess the 3.0.0 tag will suffice for this)

I also noticed that the test counts seem to vary. The CCR TCK page indicates 160 tests. Section 6.1 of the TCK Ref. guide says 164 tests, and the test results that are included later (section 9.1) shows 162 tests. This inconsistency isn't a show-stopper but if you do update it, consider ideas for refreshing these easily. It may be most expedient to to bubble this up to a read-me or other top-level document since this can frequently change right up to the release. (the sample output can be left alone with caveat text and the section 6.1 text might just refer to the TCK readme). If you do a respin for this, consider dropping a source JAR into the TCK as well.

The discrepancy in test numbers is because some of the new tests were found to be invalid and disabled/removed during the development timeframe.

njr-11 avatar Apr 27 '22 15:04 njr-11