concurrency
concurrency copied to clipboard
jakartaee
Expand TCK tests to include EJB and JSP
Based on feedback on PR: https://github.com/eclipse-ee4j/jakartaee-tck/pull/816
The standalone TCK needs to implement a similar feature as the Platform TCK vehicle infrastructure.
This means that all tests in packages ee.jakarta.tck.concurrent.api.* need to repeat each test using servlet, EJB, and JSP.
Currently, all of these tests just run on a servlet using a basic Arquillian deployment.
Proposed Solution: Each package will have a POJO class that just holds the tests we want to run. A new vehicle infrastructure package will be created with a test servlet, EJB, and JSP classes that are written to run each of the test methods from the POJO class above. An Enterprise Archive will be deployed to the application server with a servlet module, EJB module, and JSP module. An Arquillian test class will be used to package and deploy the Enterprise Archive, and repeat each test on every module.
This proposed solution will mimic how these tests currently run on the Platform TCK.
Sorry for the late comment, if you want to include EJB/JSP tests, please do, but it is not required that you do.
@scottmarlow Thanks for the feedback. I was under the impression that this WAS a requirement if we wanted to remove these tests from the Platform TCK project. Is that accurate?
Also, it should be noted that we do have EJB and JSP tests, we just don't currently re-run every test against all three platforms [Servlet/EJB/JSP]. The only tests in the Platform TCK that do "vehicle" testing are the API tests which basically just test that the correct classes are loaded and methods return the correct values.
We do EJB and JSP testing in the areas that matter, such as context propagation. If you believe this is enough to close this issue, then can we get this issue closed so we can further progress in getting these tests out of the platform TCK? FYI - @brideck
@scottmarlow Thanks for the feedback. I was under the impression that this WAS a requirement if we wanted to remove these tests from the Platform TCK project. Is that accurate?
Yes, you are correct, in that I believe the Concurrency TCK is now validating the Jakarta Platform Specification requirements for Jakarta Concurrency.
Also, it should be noted that we do have EJB and JSP tests, we just don't currently re-run every test against all three platforms [Servlet/EJB/JSP].
That sounds fine to me.
The only tests in the Platform TCK that do "vehicle" testing are the API tests which basically just test that the correct classes are loaded and methods return the correct values.
We do EJB and JSP testing in the areas that matter, such as context propagation. If you believe this is enough to close this issue, then can we get this issue closed so we can further progress in getting these tests out of the platform TCK?
:+1: from me, I just don't want to rush to merge the pull request that removes the Concurrency tests until next week (so that others might still give feedback on this).
Awesome thanks for all the feedback @scottmarlow. I'll go ahead and update the mailing list so we can drum up support (or opposition).