RaiWebWallet icon indicating copy to clipboard operation
RaiWebWallet copied to clipboard

Add package json and delete node_modules

Open weeska opened this issue 7 years ago • 5 comments
trafficstars

Hi there.

I thought it would be more straight-forward to have a package.json describing the project's dependencies. I don't know if you're familiar with node.js, but this way you can just type npm install and it installs all dependencies - no need to push them.

Things that I've changed:

  • use npm init to create a package.json
  • Delete node_modules folder
  • add .gitignore

weeska avatar Dec 21 '17 20:12 weeska

Not all dependencies are resolved yet, hum? It's not possible to use as node dependency. I think core could be split as standalone library.

bkmeneguello avatar Dec 22 '17 00:12 bkmeneguello

This need to be done ASAP because no professional developers would commit node_modules into git. This will more or less affect the RaiWallet credibility

s123121 avatar Dec 22 '17 04:12 s123121

@bkmeneguello npm init automatically writes packages from the node_modules folder into the generated package.json. So all dependencies should be resolved. I also removed the nacl folder as it did not seem to be used.

I wonder if there is some sort of CI system. It's hard to see what's effected by changes.

weeska avatar Dec 22 '17 08:12 weeska

Hmm @chriscohoat did the same here: https://github.com/jaimehgb/RaiWebWallet/pull/5

He also moved Wallet.js and Block.js (the wallet itself) into a new and self-contained repo: https://github.com/chriscohoat/rai-wallet

I think that's the way to do it, still have to test his branch though (cough) :)

jaimehgb avatar Dec 22 '17 14:12 jaimehgb

I'm fine with closing this one if the PR of @chriscohoatgets gets merged. Either way there is some work to be done to enable other developers to help.

weeska avatar Dec 30 '17 16:12 weeska